https://bugzilla.redhat.com/show_bug.cgi?id=1168333



--- Comment #8 from Michael Adam <ma...@redhat.com> ---
Ok, now this is really strange:
While I can build these srpms with mock without problems, and have also built
them on copr (https://copr.fedoraproject.org/coprs/obnox/vagrant-libvirt/), I
can't seem to run "fedora-review" on them, neither with the bug number nor
specifying the srpm/spec locally. This fails immediately with:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

$ fedora-review -m fedora-rawhide-x86_64 -n vagrant-libvirt   
INFO: Processing local files: vagrant-libvirt
INFO: Getting .spec and .srpm Urls from : Local files in
/home/obnox/review/vagrant-libvirt/0.0.24-1/tmp
INFO:   --> SRPM url:
file:///home/obnox/review/vagrant-libvirt/0.0.24-1/tmp/vagrant-libvirt-0.0.24-1.fc22.src.rpm
INFO:   --> Spec url:
file:///home/obnox/review/vagrant-libvirt/0.0.24-1/tmp/vagrant-libvirt.spec
INFO: Using review directory:
/home/obnox/review/vagrant-libvirt/0.0.24-1/tmp/review-vagrant-libvirt
RPM version 4.12.0.1
Copyright (C) 1998-2002 - Red Hat, Inc.
This program may be freely redistributed under the terms of the GNU GPL

Usage: rpm [-afgpcdLlsiv?] [-a|--all] [-f|--file] [-g|--group] [-p|--package]
[--pkgid] [--hdrid]
        [--triggeredby] [--whatrequires] [--whatprovides] [--nomanifest]
[-c|--configfiles] [-d|--docfiles]
        [-L|--licensefiles] [--dump] [-l|--list] [--queryformat=QUERYFORMAT]
[-s|--state] [--nofiledigest]
        [--nofiles] [--nodeps] [--noscript] [--allfiles] [--allmatches]
[--badreloc] [-e|--erase=<package>+]
        [--excludedocs] [--excludepath=<path>] [--force]
[-F|--freshen=<packagefile>+] [-h|--hash] [--ignorearch]
        [--ignoreos] [--ignoresize] [-i|--install] [--justdb] [--nodeps]
[--nofiledigest] [--nocontexts]
        [--noorder] [--noscripts] [--notriggers] [--oldpackage] [--percent]
[--prefix=<dir>]
        [--relocate=<old>=<new>] [--replacefiles] [--replacepkgs] [--test]
[-U|--upgrade=<packagefile>+]
        [--reinstall=<packagefile>+] [-D|--define='MACRO EXPR']
[--undefine=MACRO] [-E|--eval='EXPR']
        [--macros=<FILE:...>] [--noplugins] [--nodigest] [--nosignature]
[--rcfile=<FILE:...>] [-r|--root=ROOT]
        [--dbpath=DIRECTORY] [--querytags] [--showrc] [--quiet] [-v|--verbose]
[--version] [-?|--help]
        [--usage] [--scripts] [--setperms] [--setugids] [--conflicts]
[--obsoletes] [--provides] [--requires]
        [--recommends] [--suggests] [--supplements] [--enhances] [--info]
[--changelog] [--xml] [--triggers]
        [--last] [--dupes] [--filesbypkg] [--fileclass] [--filecolor]
[--fscontext] [--fileprovide]
        [--filerequire] [--filecaps]
ERROR: Exception down the road...(logs in /home/obnox/.cache/fedora-review.log)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and the contents of the logfile:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
01-22 21:37 root         DEBUG    fedora-review 0.5.2 63c24cb 2014-07-14
15:08:50 +0200 started
01-22 21:37 root         DEBUG    Command  line: /usr/bin/fedora-review -m
fedora-rawhide-x86_64 -n vagrant-libvirt
01-22 21:37 root         INFO     Processing local files: vagrant-libvirt
01-22 21:37 root         INFO     Getting .spec and .srpm Urls from : Local
files in /home/obnox/review/vagrant-libvirt/0.0.24-1/tmp
01-22 21:37 root         DEBUG    Active settings after processing options
01-22 21:37 root         DEBUG        resultdir: None
01-22 21:37 root         DEBUG        verbose: False
01-22 21:37 root         DEBUG        no_report: False
01-22 21:37 root         DEBUG        session_log:
/home/obnox/.cache/fedora-review.log
01-22 21:37 root         DEBUG        list_flags: False
01-22 21:37 root         DEBUG        list_checks: False
01-22 21:37 root         DEBUG        single: None
01-22 21:37 root         DEBUG        rpm_spec: False
01-22 21:37 root         DEBUG        plugins: {}
01-22 21:37 root         DEBUG        exclude: None
01-22 21:37 root         DEBUG        configdir: None
01-22 21:37 root         DEBUG        log_level: 20
01-22 21:37 root         DEBUG        init_done: True
01-22 21:37 root         DEBUG        cache: False
01-22 21:37 root         DEBUG        mock_config: fedora-rawhide-x86_64
01-22 21:37 root         DEBUG        version: False
01-22 21:37 root         DEBUG        uniqueext: None
01-22 21:37 root         DEBUG        flags: []
01-22 21:37 root         DEBUG        bz_url: https://bugzilla.redhat.com
01-22 21:37 root         DEBUG        mock_options: --no-cleanup-after
--no-clean
01-22 21:37 root         DEBUG        list_plugins: False
01-22 21:37 root         DEBUG        _log_config_done: True
01-22 21:37 root         DEBUG        other_bz: None
01-22 21:37 root         DEBUG        plugins_arg: None
01-22 21:37 root         DEBUG        repo: None
01-22 21:37 root         DEBUG        use_colors: True
01-22 21:37 root         DEBUG        bug: None
01-22 21:37 root         DEBUG        prebuilt: False
01-22 21:37 root         DEBUG        name: vagrant-libvirt
01-22 21:37 root         DEBUG        url: None
01-22 21:37 root         DEBUG        checksum: sha256
01-22 21:37 root         DEBUG        nobuild: False
01-22 21:37 root         DEBUG        _con_handler: <logging.StreamHandler
object at 0x7f08171d70d0>
01-22 21:37 root         INFO       --> SRPM url:
file:///home/obnox/review/vagrant-libvirt/0.0.24-1/tmp/vagrant-libvirt-0.0.24-1.fc22.src.rpm
01-22 21:37 root         INFO       --> Spec url:
file:///home/obnox/review/vagrant-libvirt/0.0.24-1/tmp/vagrant-libvirt.spec
01-22 21:37 root         DEBUG    find_urls completed: 0.003
01-22 21:37 root         INFO     Using review directory:
/home/obnox/review/vagrant-libvirt/0.0.24-1/tmp/review-vagrant-libvirt
01-22 21:37 root         DEBUG    Avoiding init of working mock root
01-22 21:37 root         DEBUG    Url download completed: 2.886
01-22 21:37 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line
232, in run
    self._do_run(outfile)
  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line
222, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line
96, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python2.7/site-packages/FedoraReview/review_helper.py", line
105, in _run_checks
    self.checks = Checks(spec, srpm)
  File "/usr/lib/python2.7/site-packages/FedoraReview/checks.py", line 271, in
__init__
    self.spec = SpecFile(spec_file, self.flags)
  File "/usr/lib/python2.7/site-packages/FedoraReview/spec_file.py", line 91,
in __init__
    update_macros()
  File "/usr/lib/python2.7/site-packages/FedoraReview/spec_file.py", line 65,
in update_macros
    expanded = Mock.get_macro(macro, self, flags)
  File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 346, in
get_macro
    self._macros = self._get_default_macros()
  File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 134, in
_get_default_macros
    values = self._rpm_eval(tags).split()
  File "/usr/lib/python2.7/site-packages/FedoraReview/mock.py", line 259, in
_rpm_eval
    return check_output(cmd).decode('utf-8').strip()
  File "/usr/lib64/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['mock', '-r', 'fedora-rawhide-x86_64',
'--no-cleanup-after', '--no-clean',
'--resultdir=/home/obnox/review/vagrant-libvirt/0.0.24-1/tmp/review-vagrant-libvirt/results',
'--quiet', '--shell', 'rpm --eval \\"%dist %fedora %epel %buildarch %_libdir
%_isa %arch\\"']' returned non-zero exit status 9
01-22 21:37 root         ERROR    Exception down the road...(logs in
/home/obnox/.cache/fedora-review.log)
01-22 21:37 root         DEBUG    Report completed:  3.518 seconds
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

When I manually copy the command and run it the via mock it works:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$ mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean
--resultdir=/home/obnox/review/vagrant-libvirt/1168333-vagrant-libvirt/results
--shell 'rpm --eval "%dist %fedora %epel %buildarch %_libdir %_isa %arch"'
INFO: mock.py version 1.2.4 starting (python version = 2.7.8)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled yum cache
Start: cleaning yum metadata
Finish: cleaning yum metadata
INFO: enabled ccache
Finish: chroot init
Start: shell
.fc22 22 %epel %buildarch /usr/lib64 (x86-64) %arch
Finish: shell
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

but there seems to be a quotation problem inside fedora-review:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$ mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean
--resultdir=/home/obnox/review/vagrant-libvirt/1168333-vagrant-libvirt/results
--shell 'rpm --eval \"%dist %fedora %epel %buildarch %_libdir %_isa %arch\"'
INFO: mock.py version 1.2.4 starting (python version = 2.7.8)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled yum cache
Start: cleaning yum metadata
Finish: cleaning yum metadata
INFO: enabled ccache
Finish: chroot init
Start: shell
".fc22
RPM version 4.12.0.1
Copyright (C) 1998-2002 - Red Hat, Inc.
This program may be freely redistributed under the terms of the GNU GPL

Usage: rpm [-afgpcdLlsiv?] [-a|--all] [-f|--file] [-g|--group] [-p|--package]
[--pkgid] [--hdrid]
        [--triggeredby] [--whatrequires] [--whatprovides] [--nomanifest]
[-c|--configfiles] [-d|--docfiles]
        [-L|--licensefiles] [--dump] [-l|--list] [--queryformat=QUERYFORMAT]
[-s|--state] [--nofiledigest]
        [--nofiles] [--nodeps] [--noscript] [--allfiles] [--allmatches]
[--badreloc] [-e|--erase=<package>+]
        [--excludedocs] [--excludepath=<path>] [--force]
[-F|--freshen=<packagefile>+] [-h|--hash] [--ignorearch]
        [--ignoreos] [--ignoresize] [-i|--install] [--justdb] [--nodeps]
[--nofiledigest] [--nocontexts]
        [--noorder] [--noscripts] [--notriggers] [--oldpackage] [--percent]
[--prefix=<dir>]
        [--relocate=<old>=<new>] [--replacefiles] [--replacepkgs] [--test]
[-U|--upgrade=<packagefile>+]
        [--reinstall=<packagefile>+] [-D|--define='MACRO EXPR']
[--undefine=MACRO] [-E|--eval='EXPR']
        [--macros=<FILE:...>] [--noplugins] [--nodigest] [--nosignature]
[--rcfile=<FILE:...>] [-r|--root=ROOT]
        [--dbpath=DIRECTORY] [--querytags] [--showrc] [--quiet] [-v|--verbose]
[--version] [-?|--help]
        [--usage] [--scripts] [--setperms] [--setugids] [--conflicts]
[--obsoletes] [--provides] [--requires]
        [--recommends] [--suggests] [--supplements] [--enhances] [--info]
[--changelog] [--xml] [--triggers]
        [--last] [--dupes] [--filesbypkg] [--fileclass] [--filecolor]
[--fscontext] [--fileprovide]
        [--filerequire] [--filecaps]
Finish: shell
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

But I am currently at a loss what triggers it.
What can I have done to the srpm? I did not change a lot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to