https://bugzilla.redhat.com/show_bug.cgi?id=1184920
Vít Ondruch <vondr...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-cvs?
--- Comment #3 from Vít Ondruch <vondr...@redhat.com> ---
(In reply to Josef Stribny from comment #2)
> * Extra space before a dot:
>
> "Dom and Selector assertions for Rails applications ."
I already fixed this locally.
> * Wrong upstream URL:
>
> https://github.com/rails/rails-dom-testing is the new official URL from
> which the latest release comes from. Upstream should probably fix that in
> .gemspec.
Hmm, not sure about this. I checked the former URL and the URL you are
referencing and both are valid/the same ATM, where the one in .gemspec is fork
of the one you are referencing. I prefer to keep the .gemspec one ATM and will
see what will future bring.
> Otherwise everything looks sane, package builds and runs, rpmlint does not
> complain about anything meaningful. ==> APPROVED. Please fix the above
> before pushing.
Thanks for the review.
New Package SCM Request
=======================
Package Name: rubygem-rails-dom-testing
Short Description: Compares doms and assert certain elements exists in doms
using Nokogiri
Upstream URL: https://github.com/kaspth/rails-dom-testing
Owners: vondruch jstribny
Branches:
InitialCC:
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
