https://bugzilla.redhat.com/show_bug.cgi?id=1182770



--- Comment #4 from Ken Dreyer <ktdre...@ktdreyer.com> ---
Thanks Remi for the review comments.

This backport was developed primarily for Ceph's RADOS Gateway software, and I
don't think SetHandler was part of the design goals. I've opened a pull request
to clarify this in the README. https://github.com/ceph/mod-proxy-fcgi/pull/2

The reason I hardcoded the "< 2.3" and the "= 20051115" and added a note in the
%description was because I wanted it to be crystal clear to users that this
package is only for httpd 2.2 / RHEL 6, and users shouldn't try to rebuild the
SRPM for anything else.

Maybe I was overly concerned about that. I've made the adjustments you've
requested in the new version.

* Mon Jan 26 2015 Ken Dreyer <kdre...@redhat.com> - 2.4.10-2
- Adjustments for package review (RHBZ #1182770)
- Dynamically determine %%{_httpd_mmn} instead of hardcoding
- Drop explicit requirement on httpd < 2.3
- Add a note to %%description regarding the lack of SetHandler support
- Update .conf file to load the module by default

Exact changes in Git:
https://fedorapeople.org/cgit/ktdreyer/public_git/mod_proxy_fcgi.git/commit/?h=el6&id=6bd994d0c84697ffe02e8950e9bd31337e65e771

Spec URL: https://ktdreyer.fedorapeople.org/reviews/mod_proxy_fcgi.spec
SRPM URL:
https://ktdreyer.fedorapeople.org/reviews/mod_proxy_fcgi-2.4.10-2.el6.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to