https://bugzilla.redhat.com/show_bug.cgi?id=1176595
--- Comment #7 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.mich...@gmx.net> --- > This is not mentioned on fedora packaging guideline wiki but I got > this feedback for my package from package reviewer There is absolutely no technical reason to split BuildRequires into separate lines. Whatever the reviewer has recommended to you is personal preference, a matter of style. It can be problematic to request new contributors to do things like that. > In %files section, %defattr is not needed unless you are changing default > permission Explained here: https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions > Also, its good to give successful scratch build link of package in koji Running "fedora-review -b 1176595" would be a great idea. It's not a simple package, so there are quite some things to check, such as the dependency filtering. And the base package dependencies of all subpackages: | %package devel | Summary: Development files for %name | Requires: hypre = %{version} https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
