https://bugzilla.redhat.com/show_bug.cgi?id=1187224
Dan Horák <d...@danny.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #2 from Dan Horák <d...@danny.cz> ---
formal review is here, see the notes explaining OK* and BAD statuses below:
OK source files match upstream:
ca04e8399194a70b10993552ce01b4551bad56ea
backport_collections-0.1.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (Python). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK package builds in mock (EPEL-6/x86_64).
N/A debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
OK %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
Ok owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- my preference is to list BRs on individual lines, it is easier to track
changes there
- rpmlint complains a bit from the spell-checker - please fix the "slightly"
typo
python-backport_collections.src: W: spelling-error Summary(en_US) Backport ->
Back port, Back-port, Backpacker
python-backport_collections.src: W: spelling-error %description -l en_US
Backport -> Back port, Back-port, Backpacker
python-backport_collections.src: W: spelling-error %description -l en_US deque
-> queue
python-backport_collections.src: W: spelling-error %description -l en_US
namedtuple -> nameplate
python-backport_collections.src: W: spelling-error %description -l en_US
backported -> back ported, back-ported, backpacked
python-backport_collections.src: W: spelling-error %description -l en_US
slighlty -> slightly, slight
The package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
