https://bugzilla.redhat.com/show_bug.cgi?id=1091659



--- Comment #20 from Dave Johansen <davejohan...@gmail.com> ---
In reply to comment #18:

> 1. Install cleanup.

Fixed.

> 2a. Specify Python 2 in script

The sed gave the following error:
sed: -e expression #1, char 32: unknown option to `s'

So I used this instead:
sed -i '1 s|^#!/usr/bin/python\b|#!%{__python2}|' fix_includes.py

> 2b. BR python2-devel.

Fixed.

> 3. Drop Group tag.

Fixed.

> 4. use %{__python2} instead of directly executing.

Fixed

> 5. Consider virtual provides of that obtuse name:

Fixed

> 6. manpage can be ignored since help has been written into the python 
> executables.

Agreed, because there's no manpage in the upstream source.


The updated .spec and source .rpm can be found at the URLs listed in comment 15
with the fixes above.


Additional Question:
Currently, the version is set to 3.5 because that's what the tarball is called,
but when you run "iwyu --version" it says 0.3 and I believe that's probably the
more correct value. But when I change it, %setup chokes on the filename of the
tar. Is there a way that I can get %setup to untar the file properly when I set
the Version tag to 0.3?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to