https://bugzilla.redhat.com/show_bug.cgi?id=1194545
Adam Williamson (Red Hat) <awill...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |awill...@redhat.com
--- Comment #1 from Adam Williamson (Red Hat) <awill...@redhat.com> ---
you don't need to define sitearch, and it's 'good practice' to make
sitelib/sitearch definition conditional on old EL and version specific:
%if 0%{?rhel} && 0%{?rhel} <= 6
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%endif
then use python2_sitelib not python_sitelib (this is all from
https://fedoraproject.org/wiki/Packaging:Python ).
The packaging guidelines require using commit-based tarballs when using
github-generated sources, not versions:
https://fedoraproject.org/wiki/Packaging:SourceURL#Github
that can be a bit tricky to read, but yes, it really does mean you should use a
tarball derived from a commit hash even for stable releases, unless upstream
provides tarballs in some way *other* than github's generation system. The
justification is that commit hashes are less mutable and thus more predictable,
so we should take advantage of that when we can. You can still version the
package as 1.0.0-1 , but the Source0 URL should use a commit hash. See
http://pkgs.fedoraproject.org/cgit/php-google-apiclient.git/tree/php-google-apiclient.spec
for an example.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
