https://bugzilla.redhat.com/show_bug.cgi?id=1195279
--- Comment #12 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> --- (In reply to Petr Hracek from comment #10) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #9) > > Created attachment 996036 [details] > > fedora-review output > > > > (In reply to Petr Hracek from comment #8) > > > > > Regarding configparser. All is working properly. > > > > > configparser.py provides class ConfigParser in F22 and in F23 too. > > > > > This was not changed. > > > > The class name did not change. But the module name did. > > > > > > Well, I have checked the class name and module name configparser.py and > > > both > > > are identical. F22 and F23. > > It changed between Python 2 and 3. In comment #c5 there's a code snippet to > > make the code compatible with both versions. > Only Python3 is supported by preupgrade-assistant OK. > > OK, I see you removed %check. This is *not* the way to go. If the tests find > > a problem, fix the problem, don't remove the tests! > > > I am going to add them later on. This BZ blocks a Feature for Fedora 22. The tests are helpful. They already caught a silly bug, so it seems right to keep them, even in F22. > > We are going in circles. Let's go back to the beginning, and start with the > > basic questions: > > > > - what python version is preupgrade-assistant supposed to run? Is it going > > to be packaged for F21? Is the answer the same for both F23 and F22 and > > F21? > > > Preupgrade-assistant is going to be used only for F22 and later. Not F21. > > Some data points: > > - in F22 pykickstart is at 1.99.66 and does *not* provide a python 3 version > I know that. Therefore in SPEC file is mentioned if fedora is bigger then 23 > then include python3-kickstart. But you cannot use pykickstart (a Python2-only package) with a program running under Python 3. If preupgrade-assistant is Python3-only, then any Requires:pykickstart or BuildRequires:pykickstart can to be removed. Can pykickstart version in F22 be updated to the same version as F23? This would solve the problem with missing dependency for you. > > - in F23 pykickstart is at 2.0 and does provide python3-kickstart > > - the version in F21 is even older and does Python 2 only > No F21. OK. > > - the code in ./preuputils/oscap_group_xml.py is atm Python2 only > I have forgot that. I am going to change that in the next version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
