Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=615577 Randall Berry <randyn3...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |randyn3...@gmail.com --- Comment #4 from Randall Berry <randyn3...@gmail.com> 2010-07-18 05:14:45 EDT --- Is this your first package? If so you will need a sponsor. The spec file still does not address the licensing issue. You have "Apache License" when it should be "ASL 2.0" This is important because in some cases Version 1 of a license may not be acceptable whereas version 2 is. This is not the case with the Apache Software License but the version is just as important. Documentation is here: http://fedoraproject.org/wiki/Licensing#Good_Licenses BuildRequires: gettext-devel should be: BuildRequires: gettext http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files %files libs -f %{name}.lang Are you sure this is correct? Should the locale files be in the binary %files section? Usually libs do their work in the background and don't need locale files. Locales are normally handled by the user interface. I may be wrong but it was worth looking into. rpmlint output: opencc-libs.i686: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Runtish opencc-libs.i686: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Runtish opencc-libs.i686: W: invalid-license Apache License opencc-libs.i686: W: shared-lib-calls-exit /usr/lib/libopencc.so.0.0.0 e...@glibc_2.0 opencc-libs.i686: W: no-documentation opencc-libs.i686: E: library-without-ldconfig-postin /usr/lib/libopencc.so.0.0.0 opencc-libs.i686: E: library-without-ldconfig-postun /usr/lib/libopencc.so.0.0.0 opencc-devel.i686: W: invalid-license Apache License opencc-devel.i686: W: no-documentation opencc.i686: W: invalid-license Apache License opencc.i686: E: standard-dir-owned-by-package /usr/share/man/man1 opencc.i686: W: empty-%post opencc.src: W: invalid-license Apache License opencc-debuginfo.i686: W: invalid-license Apache License 5 packages and 0 specfiles checked; 3 errors, 11 warnings. The spelling warnings can be ignored but the other issues must be addressed. No documentation. This can also be ignored but it would be nice if there was documentation. Documentation on the library-without-ldconfig* can be found here: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries File/Directory ownership documentation is here: http://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership When you make changes as instructed by the reviewer for each revision bump the release number up one, comment the changes in the %changelog section and build and upload a new SRPM. This is so we know where we are and what changes have been made. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
