https://bugzilla.redhat.com/show_bug.cgi?id=1201662
--- Comment #9 from Jonathan Underwood <jonathan.underw...@gmail.com> ---
Still some rpmlint flagged issues:
(1)
wiredtiger.src:66: W: rpm-buildroot-usage %build sed -i -r
"s|(\(PYTHON_INSTALL_ARG\))|\1 --no-compile --install-dir
%{buildroot}%{python_sitelib}|" lang/python/Makefile.am
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.
This is because you're doing loads of stuff in %build that should be done in
%prep. All of this should be in %prep:
# Fix installing python files into BUILDROOT
sed -i -r "s|(\(PYTHON_INSTALL_ARG\))|\1 --no-compile --install-dir
%{buildroot}%{python_sitelib}|" lang/python/Makefile.am
%configure --disable-static --with-builtins=zlib,snappy --enable-python
--enable-java JAR="%{java_home}/bin/jar"
# Stop the build setting up an rpath
sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
The only thing in %build should be:
make %{?_smp_mflags} CFLAGS="%{optflags}"
(2)
wiredtiger-devel.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
This one is because /usr/lib64/libwiredtiger.so is a symbolic link - no action
needed.
(3)
wiredtiger-python.x86_64: E: non-standard-executable-perm
/usr/lib/python2.7/site-packages/wiredtiger/_wiredtiger.so 0775L
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.
This is a compiled extension, and so should be under %{python_sitearch}, rather
than under %{python_sitelib}. The former is for compiled extension modules, the
latter for pure python (arch independent) modules. See:
http://fedoraproject.org/wiki/Packaging:Python
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
