https://bugzilla.redhat.com/show_bug.cgi?id=1206086
Chandan Kumar <chku...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chku...@redhat.com
--- Comment #1 from Chandan Kumar <chku...@redhat.com> ---
This is un-official review of the package.
Suggestions:
[1.] Group tag is optional in Fedora and is only needed if you want this
package to be built for EPEL5. See
http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag. You can remove Group
tag from both package and sub-package.
[2.] Change the URL from launchpad to pypi,
URL: https://pypi.python.org/pypi/oslo.versionedobjects
[3.] Use %{version} tag in Source0
Source0:
https://pypi.python.org/packages/source/o/%{sname}/%{sname}-%{version}.tar.gz
[4.] Move doc building steps from %install section to %build section
export PYTHONPATH="$( pwd ):$PYTHONPATH"
pushd doc
sphinx-build -b html -d build/doctrees source build/html
popd
# Fix hidden-file-or-dir warnings
rm -fr doc/build/html/.buildinfo
[5.] Mock build is failing and giving:
Extension error:
Could not import extension oslosphinx (exception: No module named oslosphinx)
To fix this:
Add this line in %prep section:
# make doc build compatible with python-oslo-sphinx RPM
sed -i 's/oslosphinx/oslo.sphinx/' doc/source/conf.py
[6.] in %files section, please include other files also present in the python
package tarball.
%doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
