https://bugzilla.redhat.com/show_bug.cgi?id=1202805
Paul Howarth <p...@city-fan.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p...@city-fan.org
--- Comment #3 from Paul Howarth <p...@city-fan.org> ---
Things I noticed from a quick look at the spec file:
The package does not need to provide itself:
Provides: owncloud-client = %{version}-%{release}
Should the Obsoletes have associated Provides? Will the package be going to
anywhere other than Rawhide?
The description and summary of the common sub-package need tidying up:
"... common files for owncloud-client and owncloud-client ..."
(Summaries and Descriptions should also generally start with a capital letter)
Use %license rather than %doc for COPYING
There should be a virtual -static provide for the libhttpbf.a static library:
http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
