Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=615849 Ankur Sinha <sanjay.an...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Ankur Sinha <sanjay.an...@gmail.com> 2010-07-19 06:37:37 EDT --- + OK - NA ? ISSUE + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. - Sources match upstream md5sum: - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. ? Package has a correct %clean section. ? Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. SHOULD Items: + Should build in mock. - Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag - Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. Again, please make sure the package is for F13+ since you're not using a clean section etc. 2. rpmlint output: [an...@localhost SPECS]$ rpmlint oflb-icelandic-fonts.spec ../SRPMS/oflb-icelandic-fonts-1.001-9.fc13.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm oflb-icelandic-fonts.spec: W: no-cleaning-of-buildroot %install oflb-icelandic-fonts.spec: W: no-cleaning-of-buildroot %clean oflb-icelandic-fonts.spec: W: no-buildroot-tag oflb-icelandic-fonts.spec: W: no-%clean-section oflb-icelandic-fonts.spec: W: invalid-url Source0: http://openfontlibrary.org/people/asyropoulos/asyropoulos_-_Icelandic.otf HTTP Error 404: Not Found oflb-icelandic-fonts.src: W: spelling-error %description -l en_US staves -> staved, stave, saves oflb-icelandic-fonts.src: W: spelling-error %description -l en_US www -> WWW, waw, wow oflb-icelandic-fonts.src: W: spelling-error %description -l en_US galdrasyning -> galvanizing, galligaskins, hydrastinine oflb-icelandic-fonts.src: W: invalid-url URL: http://openfontlibrary.org/media/files/asyropoulos/238 HTTP Error 404: Not Found oflb-icelandic-fonts.src: W: no-cleaning-of-buildroot %install oflb-icelandic-fonts.src: W: no-cleaning-of-buildroot %clean oflb-icelandic-fonts.src: W: no-buildroot-tag oflb-icelandic-fonts.src: W: no-%clean-section oflb-icelandic-fonts.src: W: invalid-url Source0: http://openfontlibrary.org/people/asyropoulos/asyropoulos_-_Icelandic.otf HTTP Error 404: Not Found oflb-icelandic-fonts.noarch: W: spelling-error %description -l en_US staves -> staved, stave, saves oflb-icelandic-fonts.noarch: W: spelling-error %description -l en_US www -> WWW, waw, wow oflb-icelandic-fonts.noarch: W: spelling-error %description -l en_US galdrasyning -> galvanizing, galligaskins, hydrastinine oflb-icelandic-fonts.noarch: W: invalid-url URL: http://openfontlibrary.org/media/files/asyropoulos/238 HTTP Error 404: Not Found oflb-icelandic-fonts.src: W: spelling-error %description -l en_US staves -> staved, stave, saves oflb-icelandic-fonts.src: W: spelling-error %description -l en_US www -> WWW, waw, wow oflb-icelandic-fonts.src: W: spelling-error %description -l en_US galdrasyning -> galvanizing, galligaskins, hydrastinine oflb-icelandic-fonts.src: W: invalid-url URL: http://openfontlibrary.org/media/files/asyropoulos/238 HTTP Error 404: Not Found oflb-icelandic-fonts.src: W: no-cleaning-of-buildroot %install oflb-icelandic-fonts.src: W: no-cleaning-of-buildroot %clean oflb-icelandic-fonts.src: W: no-buildroot-tag oflb-icelandic-fonts.src: W: no-%clean-section oflb-icelandic-fonts.src: W: invalid-url Source0: http://openfontlibrary.org/people/asyropoulos/asyropoulos_-_Icelandic.otf HTTP Error 404: Not Found 3 packages and 1 specfiles checked; 0 errors, 27 warnings. Ignorable warnings. URL error due to dead font upstream XXX APPROVED XXX -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
