https://bugzilla.redhat.com/show_bug.cgi?id=1230874
--- Comment #11 from Jie Kang <jk...@redhat.com> --- (In reply to Severin Gehwolf from comment #9) > %global source maven-scr-plugin > > Please call this "artifactId" or some such. "source" seems too generic and > is very confusing when working with RPMs since a source is generally some > tarball or a config file or... Okay, changed to 'artifactId' > > > # For building from source tarball > Source0: > http://www.apache.org/dist/felix/%{source}-%{version}-source-release.tar.gz > > Please drop this "For building from source tarball" comment. It doesn't > really make sense. Everything is built from source. Done. > > Looks good otherwise. I have also updated the changelog as per your comment -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
