https://bugzilla.redhat.com/show_bug.cgi?id=894609
--- Comment #12 from Paulo Andrade <paulo.cesar.pereira.de.andr...@gmail.com> --- (In reply to Antonio Trande from comment #11) Thanks for the review! > - Please, fix URL tag. It is correct, try opening http://http://projects.coin-or.org/OS but it has some issue with the ssl certificate. In firefox, there will be an exclamation mark icon right of the link, with the tooltip: "This website does not supply identity information." > - LICENSE is correctly tagged as %license > > - There is code licensed with GPL license and involved > in package building. License tag should indicate GPL code too. This was the reason it took some time for the next review. It bundles preprocessed bison and flex files, but it now regenerate the parsers. See http://www.gnu.org/software/bison/manual/bison.html#Conditions The files are also regenerated at build time, so the "exceptions" ally: ---8<--- OS-2.9.3/src/OSParsers/OSParseosrl.tab.cpp: /* A Bison parser, made by GNU Bison 2.4.1. */ ... /* As a special exception, you may create a larger work that contains part or all of the Bison parser skeleton and distribute that work under terms of your choice, so long as that work isn't itself a parser generator using the skeleton or a modified version thereof as a parser skeleton. Alternatively, if you modify or redistribute the parser skeleton itself, you may (at your option) remove this special exception, which will cause the skeleton and the resulting Bison output files to be licensed under the GNU General Public License without this special exception. This special exception was added by the Free Software Foundation in version 2.2 of Bison. */ ... ---8<--- > http://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#Mixed_Source_Licensing_Scenario > > - Why documentation is not packaged? My bad :) it was broken at some point, but fixed now! > - Please, fix 'unused-direct-shlib-dependency' warnings. > See rpmlint (installed packages) I am unsure about these, because it would mean changing RPM_LD_FLAGS, by adding -Wl,--as-needed to LDFLAGS. Maybe these are one of the cases rpmlint is being too much verbose? Anyway, I changed it avoid overlinking. Update: - Build documentation (#894609#c11) - Do not overlink generated library (#894609#c11) - Update file list when asl is disabled Spec URL: http://pcpa.fedorapeople.org/coin-or/coin-or-OS.spec SRPM URL: http://pcpa.fedorapeople.org/coin-or/coin-or-OS-2.9.3-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
