Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=583327 Kalev Lember <ka...@smartlink.ee> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ka...@smartlink.ee --- Comment #14 from Kalev Lember <ka...@smartlink.ee> 2010-07-23 18:05:18 EDT --- (In reply to comment #10) > (In reply to comment #8) > > - Guidelines say cmake projects should use "make VERBOSE=1": > > https://fedoraproject.org/wiki/Packaging/cmake > > > > That makes the build logs, as one can guess, verbose. clementine's logs were > verbose by default, but I added it, just in case things change in the future. The reason why clementine's logs were already verbose is that the %cmake macro has -DCMAKE_VERBOSE_MAKEFILE=ON switch. When the guidelines were first approved %cmake macro didn't have this switch; it is something that was added later but it looks like people have forgotten to update the guidelines. The spec file doesn't seem to run icon cache scriplets, but I think it should as it's putting files into %{_datadir}/icons/hicolor/. Also, one of the icons is named application-x-clementine.png which looks like it's an icon for application/x-clementine mime type. I didn't check the .desktop file if it really has mimetype entry, but if it does, then you should also add desktop-database updating scriplets. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
