Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=617797 --- Comment #2 from Mamoru Tasaka <mtas...@ioa.s.u-tokyo.ac.jp> 2010-07-24 13:44:40 EDT --- Well, another interesting file manager :) Some notes: ! python2 vs python3 - As your spec file uses %{python_sitelib} which is python2 specific macro, I think explicitly writing "BR: python2-devel" rather than "BR: python-devel" is preferable. https://fedoraproject.org/wiki/Packaging/Python#BuildRequires ! BuildRoot - BuildRoot tag is no longer needed on Fedora (only needed on EPEL5) https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag ! default %setup - By default %setup uses "%{name}-%{version}". so explicitly writing "-n %{name}-%{version}" is not needed. * rpmlint issue --------------------------------------------------------- ranger.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ranger/__main__.py 0644L /usr/bin/env --------------------------------------------------------- - This file need not have shebang. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review