Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226346 --- Comment #6 from Jussi Lehtola <jussi.leht...@iki.fi> 2010-07-25 06:27:53 EDT --- (In reply to comment #1) > - The source url disclaimer must be added > http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream This has actually changed since my review. Now we don't allow exceptions of any kind, so you must create a project homepage at e.g. Fedora Hosted https://fedorahosted.org/web/. ** The BuildRoot tag is obsolete. Please modernize to %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) or remove it altogether, since it's no longer needed on newer Fedoras. ** rpmlint now stands as: python-pyblock.src:12: W: macro-in-comment %{version} python-pyblock.src:12: W: macro-in-comment %{release} python-pyblock.src: W: invalid-url Source0: pyblock-0.49.tar.bz2 python-pyblock.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/block/dmraidmodule.so dmraidmodule.so.0.49()(64bit) python-pyblock.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/block/dmmodule.so dmmodule.so.0.49()(64bit) 3 packages and 0 specfiles checked; 0 errors, 5 warnings. You might want to prepend the macros in comments with an additional % to prevent expansion. ** The build system is IMHO rather unusual for a python module. This probably explains the lack of an egg that is normally present in Python packages. ** Note that the package could also be named simply 'pyblock', as this is allowed per the Naming Guidelines. ** (In reply to comment #5) > Note I've not changed the dir where the documentation > gets installed as I see no reason for that. Now the location of the documentation is rather unorthodox, since the name of the docdir does not equal that of the package itself. ** Otherwise, everything seems to be in condition. Please address the issues listed above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
