https://bugzilla.redhat.com/show_bug.cgi?id=1203018
--- Comment #16 from Jonathan Underwood <jonathan.underw...@gmail.com> --- Hi Macin, some points fro looking over the spec file: 1) Please update the Release tag each time you make a change, and add a %changelog entry 2) What is the rationale behind the %post and %preun snippets that create/remove those symlinks? Why can they not simply be created in %install and packaged? At the very least the spec file needs some comments explaining why these operations are done in %post and %preun, but better would be find a way to not have to do that there. 3) It's not obligatory, but it strikes me that you do a lot of work manually in %install that would more normally be handled with a Makefile shipped with the upstream tarball. Since you're also upstream, have you considered using a Makefile (or autotools) to simplify installation for users and other distros in general? 4) adding a sub-package for apache configuration would adviseable 5) See all of Dominik's points above :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
