https://bugzilla.redhat.com/show_bug.cgi?id=1244102
--- Comment #8 from Marcin Haba <marcin.h...@bacula.pl> ---
Hello,
It looks that the source of this issue is here:
/usr/lib/python2.7/site-packages/FedoraReview/plugins/generic.py
Here is grabbing all "potential" licenses files:
for potentialfile in ['COPYING', 'LICEN', 'copying', 'licen']:
pattern = '*' + potentialfile + '*'
....[if 'COPYING', 'LICEN', 'copying' or 'licen' found in paths from rpm
content then add the file to licenses list (licenses variable)....
and next the license files are checked if exists in docs files list:
for _license in licenses:
if _license in docs:
....[test fail due to found "license" file is in docs....
The problem here is in line 791 generic.py:
pattern = '*' + potentialfile + '*'
and in consequence in 793 generic.py:
licenses = filter(lambda l: not self.rpms.find(l + '/*'), licenses)file
because pattern here is find(l + '/*')
Your package name contains in name keyword "licenses" -
"php-composer-spdx-licenses"
and from this reason it finish with test fail.
I will propose to fedora-review author change the patterm from:
pattern = '*' + potentialfile + '*'
to:
pattern = '*/' + potentialfile + '*'
Then this test case be search on files only, not paths.
I checked this change with your package and fedora-review. It works for me.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
