https://bugzilla.redhat.com/show_bug.cgi?id=1245604
--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> --- Looks good. - Name matches https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 - license is OK License file is not installed. Add %license LICENSE [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text]. %post/%postun scriplets should be suffixed with || : so that they cannot fail. I'm not a vim expert, but comparing the scriptlets with vim-taglist I see that vim-taglist removes the file, but you truncate it... Is this intentional? I don't think use should mark %{vimfiles_root}/doc/* with %doc. Packages are not allowed to use stuff marked with %doc at runtime, but this help is used by vim itself, no? Who owns %{vimfiles_root}/autoload, %{vimfiles_root}/compiler, %{vimfiles_root}/ftdetect, etc? Most likely your package should (co-)own those directories. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
