https://bugzilla.redhat.com/show_bug.cgi?id=1246657

Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panem...@gmail.com
           Assignee|nob...@fedoraproject.org    |panem...@gmail.com
              Flags|                            |fedora-review+



--- Comment #2 from Parag AN(पराग) <panem...@gmail.com> ---
Review:

+ Package koji scratch build successful F24 (x86_64)

+ rpmlint on all generated rpms gave output
nodejs-lower-case-first.noarch: W: spelling-error %description -l en_US
toString -> to String, to-string, stringing
nodejs-lower-case-first.noarch: W: spelling-error %description -l en_US
booleans -> boo leans, boo-leans, Boolean
nodejs-lower-case-first.noarch: W: only-non-binary-in-usr-lib
nodejs-lower-case-first.noarch: W: dangling-symlink
/usr/lib/node_modules/lower-case-first/node_modules/lower-case
/usr/lib/node_modules/lower-case
nodejs-lower-case-first.src: W: spelling-error %description -l en_US toString
-> to String, to-string, stringing
nodejs-lower-case-first.src: W: spelling-error %description -l en_US booleans
-> boo leans, boo-leans, Boolean
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Source verified with upstream as (sha256sum)
upstream source:
cdf2a179aaf84fd3f2f1ebff66ba9e5b52477b6ba6a19f04f6ec6591ef49fdb2
source in srpm :
cdf2a179aaf84fd3f2f1ebff66ba9e5b52477b6ba6a19f04f6ec6591ef49fdb2

+ License "MIT" is valid and included in its own file LICENSE.

+ rest follows nodejs packaging guidelines

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to