https://bugzilla.redhat.com/show_bug.cgi?id=1244797
--- Comment #4 from Michael Schwendt (Fedora Packager Sponsors Group)
<bugs.mich...@gmx.net> ---
Just a drive-by comment:
> %package devel
> Requires: cmake
Clearly overhead for a -devel package that also provides a pkg-config file.
If you only want "cmake" for directory ownership, it is permissible to include
also %{_libdir}/cmake in your package:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function
> Requires: pkgconfig
Nowadays there's an automatic dependency on /usr/bin/pkgconfig and automatic
dependencies for .pc file inter-dependencies, too. Even on RHEL6.
> %{_libdir}/cmake/%{upstream}/*.cmake
Directory %{_libdir}/cmake/%{upstream} is not included in the package.
> %exclude %{_pkgdocdir}/html
%exclude without a corresponding include of the same path name is dangerous.
%exclude hides the file(s) from all %files sections and can lead to missing
files in the built packages. Your spec file is not clear with regard to
movement/removal of some doc files, such as %{_docdir}/%{upstream}/html, and
how %_pkgdocdir/html fits into that.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
