https://bugzilla.redhat.com/show_bug.cgi?id=1248110

José Matos <jama...@fc.up.pt> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jama...@fc.up.pt



--- Comment #1 from José Matos <jama...@fc.up.pt> ---
Hi Orion,
  this is nice package. :-)

I have just a small remark, you are owning %{python3_sitelib}/__pycache__ and
according to the guideline you should not. That is you should own the files but
not the directory.
https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling

The suggestion is then to replace

%{python3_sitelib}/*

by

%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/%{srcname}*egg-info
%{python3_sitelib}/*.py

Or equivalent, you choose. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to