https://bugzilla.redhat.com/show_bug.cgi?id=1249368
--- Comment #9 from Jonathan Underwood <jonathan.underw...@gmail.com> --- Hi Scott, OK, a few things: 1) Currently the examples directory is installed in the python site packages directory. This stuff would probably be better installed as documentation, unless there's a good reason why that would hinder use somehow. 2) There's some tests under pyqtgraph/tests which should be run during %check if possible. 3) There's a doc directory with a Makefile for building documentation. I think at the least html and pdf docs should be made (you'll need a BR for sphinx) and packaged as documentation. 4) rpmlint is currently giving these errors dire to the examples having shebangs at the top, but being installed under /usr/lib. Packaging the examples as docs rather than installing them would silence these, of course. python2-pyqtgraph.noarch: E: non-executable-script /usr/lib/python2.7/site-packa ges/pyqtgraph/examples/ROItypes.py 644 /usr/bin/python python2-pyqtgraph.noarch: E: non-executable-script /usr/lib/python2.7/site-packa ges/pyqtgraph/examples/MultiPlotWidget.py 644 /usr/bin/python python2-pyqtgraph.noarch: E: non-executable-script /usr/lib/python2.7/site-packa ges/pyqtgraph/examples/ScatterPlotSpeedTest.py 644 /usr/bin/python python2-pyqtgraph.noarch: E: non-executable-script /usr/lib/python2.7/site-packa ges/pyqtgraph/examples/PlotSpeedTest.py 644 /usr/bin/python python2-pyqtgraph.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pyqtgraph/examples/MultiPlotSpeedTest.py 644 /usr/bin/python python2-pyqtgraph.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pyqtgraph/examples/ViewBox.py 644 /usr/bin/python python3-pyqtgraph.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/pyqtgraph/examples/MultiPlotWidget.py 644 /usr/bin/python python3-pyqtgraph.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/pyqtgraph/examples/ScatterPlotSpeedTest.py 644 /usr/bin/python python3-pyqtgraph.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/pyqtgraph/examples/MultiPlotSpeedTest.py 644 /usr/bin/python python3-pyqtgraph.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/pyqtgraph/examples/PlotSpeedTest.py 644 /usr/bin/python python3-pyqtgraph.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/pyqtgraph/examples/ViewBox.py 644 /usr/bin/python python3-pyqtgraph.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/pyqtgraph/examples/ROItypes.py 644 /usr/bin/python -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
