https://bugzilla.redhat.com/show_bug.cgi?id=1246974
--- Comment #12 from leinfeva <leinf...@fedoraproject.org> --- > Actually is the test suite executed at all? It seems that the test suite is > written using RSpec syntax, while you try to execute it as it was MiniTest > ... Vít I've check the gem and the helper.rb located in test folder use 'test/unit' for make the test. then as fedora wiki recommend i've add rubygem-test-unit to BuildRequires. and use MiniTest. https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites The new files: spec: https://leinfeva.fedorapeople.org/pkg-gems/rubygem-shortURL/rubygem-shorturl.spec srpm: https://leinfeva.fedorapeople.org/pkg-gems/rubygem-shortURL/rubygem-shorturl-1.0.0-4.fc23.src.rpm > > Hint: Just to explain, so far I am providing the feedback just as I am > reading through your .spec file. The definitive answer to my question would > provid link to Koji scratch build, e.g. "fedpkg scratch-build --srpm" and > this in turn helps to provide better feedback by your reviewer (or random > person interested in your package). Here is the koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10663710 And finally i've made my first package review, so any suggestion or correction about my words in the review welcome ! :D https://bugzilla.redhat.com/show_bug.cgi?id=1223774 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
