https://bugzilla.redhat.com/show_bug.cgi?id=1249078



--- Comment #9 from Pete Travis <m...@petetravis.com> ---
I've reviewed test builds on F23 and rawhide as well, and tested functionality
on F22 and F23.  There are only a few concerns:

- There's no %doc.  The docs/ and example_configs/ would be good to have,
especially since there is no manpage.  Alternatively, you could do a -docs
subpackage.

- The library files have shebangs.  These aren't executed directly - setuptools
creates a wrapper executable and drops it in /usr/bin - so they can be stripped
out with no ill effect.

- There's no py3 subpackage.  If the code works as a python3 build, you should
ship it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to