https://bugzilla.redhat.com/show_bug.cgi?id=1242090
Piotr Popieluch <piotr1...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review-
--- Comment #3 from Piotr Popieluch <piotr1...@gmail.com> ---
LICENSE must be moved to %license.
You can remove the following dependencies:
BuildRequires: npm(ip)
BuildRequires: npm(smart-buffer)
Requires: npm(ip)
Requires: npm(smart-buffer)
Those are handled automatically by nodejs-packaging scripts from package.json.
npmjs website has functional tls, I suggest changing the Source0 to https://
for security reasons. Don't think this is somewhere in the guidelines but I
think it is good practice to use https if available.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
