https://bugzilla.redhat.com/show_bug.cgi?id=1242886
Chandan Kumar <chku...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chku...@redhat.com,
| |dtant...@redhat.com
Flags| |needinfo?(dtantsur@redhat.c
| |om)
--- Comment #2 from Chandan Kumar <chku...@redhat.com> ---
Hello Dmitry,
Thanks for submitting for Package Review,
Below is my inline comments.
[1.] Since new version of openstack-ironic-inspector i.e. 2.1.0 is available,
Please update the spec file with latest version.
[2.] "Group: System Environment/Base" is not required,
Since this tag is optional, Please remove it,
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
[3.] Please check the requires with requirements.txt and please update it
[4.] Under prep section,
Please rm -rf {test-,}requirements.txt update this to rm -rf {plugin-,
test-,}requirements.txt
[5.] under %files -n python-ironic-inspector section,
please update %{python_sitelib}/ironic_inspector* to
%{python2_sitelib}/ironic_inspector*
and also include %{python2_sitelib}/ironic_inspector-%{version}-py?.?.egg-info
[6.] Please run rpmlint on srpm, rpms and spec file and make a scratch koji
build.
Thanks,
Chandan Kumar
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
