Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=567028 David Cornette <r...@davidcornette.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? --- Comment #7 from David Cornette <r...@davidcornette.com> 2010-08-01 03:30:47 EDT --- There are a few issues to address. Here is the output of rpmlint: lv2-ll-plugins.src: W: spelling-error %description -l en_US arpeggiator -> arpeggiate, arpeggio, appoggiatura lv2-ll-plugins.src:39: W: configure-without-libdir-spec lv2-ll-plugins.x86_64: W: spelling-error %description -l en_US arpeggiator -> arpeggiate, arpeggio, appoggiatura lv2-ll-plugins.x86_64: W: no-manual-page-for-binary elven /home/makerpm/rpmbuild/SPECS/lv2-ll-plugins.spec:39: W: configure-without-libdir-spec Spelling is fine. I suppose we could file a bug against the words package if we wanted to be helpful, but that isn't necessary. You should email upstream about a man page. I understand that configure isn't generated by autotools, but I am not sure you couldn't specify libdir instead of specifying lv2plugindir. It looks like lv2plugindir will be set to $(libdir)/lv2 by default, so why not just set libdir? Am I missing something? Since the elven package is capable of displaying some plugins with guis, should there be .desktop files for it to start the included gui plugins? This package needs to Require: lv2core for directory ownership. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
