https://bugzilla.redhat.com/show_bug.cgi?id=1224390
--- Comment #3 from Rich Mattes <richmat...@gmail.com> ---
> What is the relation to ignition_math2? Does it supersede this version?
Yes, it does supersede this version. Upstream adds the major version to the
tarball name, but it's the same project. I've updated the spec to the 2.2.2
release of ignition-math.
> %check is present, but the result is ignored. Is there a reason to ignore the
> result?
A test was failing on i686. I've included a patch that fixes the failing unit
test. I've also updated the spec to fail when unit tests fail, after printing
out the failure log.
> I suggest using %global _docdir_fmt %{name}.
Good call, added.
Updated spec and SRPM can be found at:
Spec URL: http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math.spec
SRPM URL:
http://rmattes.fedorapeople.org/RPMS/ignition-math/ignition-math-2.2.2-1.fc22.src.rpm
rpmlint:
$ rpmlint ignition-math.spec ../RPMS/x86_64/ignition-math-*
../RPMS/noarch/ignition-math*
ignition-math-devel.x86_64: W: only-non-binary-in-usr-lib
ignition-math-devel.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 2 warnings
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=10980494
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
