https://bugzilla.redhat.com/show_bug.cgi?id=1222484



--- Comment #3 from Juan Orti <j.orti.alca...@gmail.com> ---
(In reply to Pete Walter from comment #2)
> Looks good to me, except for two things:
> 
> 1) how did you determine it is GPLv2-only and not GPLv2+ or even GPL+? I
> can't find any notes in the source code and it includes the standard GPL
> license text file which can mean anything.
> 
> https://fedoraproject.org/wiki/Licensing:
> FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

It includes the license of GPLv2, so I assumed that. I have opened this bug:
https://github.com/lotan/rhythmbox-ampache/issues/4

> 
> 2) you install files to %{_libdir}/rhythmbox/plugins/ampache, yet the
> package is marked as noarch. noarch packages cannot include files under
> _libdir, because those are architecture dependent.

rhythmbox loads its plugins from there. The main package also places there
other python plugins like soundcloud, sendto, replaygain, rbzeitgeist, rb,
python-console.

On the other hand, I've updated the package to use python3:
Spec URL:
https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache.spec
SRPM URL:
https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache-0-0.3.20150518git7415a69.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to