Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=620177 --- Comment #3 from Kalev Lember <ka...@smartlink.ee> 2010-08-02 13:31:36 EDT --- (In reply to comment #2) > (In reply to comment #1) > > > find $RPM_BUILD_ROOT -name '*.a' -exec rm -f {} ';' > > It'd be nicer to pass --disable-static to configure so that the .a files > > don't > > get built in the first place. > > Well yeah, but as the current build system is broken I'd had to patch it for > "--disable-static" to work; and I'd rather avoid non upstream patches unless > when possible. "avoid non upstream patches"? Is upstream not accepting patches? Anyway, I tried it out with the following changes to the spec file: -%configure --enable-gtk-doc +%configure --disable-static --enable-gtk-doc find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' -find $RPM_BUILD_ROOT -name '*.a' -exec rm -f {} ';' ... and the scratch build succeeded, so I don't really believe there's something wrong with the way the build system handles --disable-static: http://koji.fedoraproject.org/koji/taskinfo?taskID=2374115 Also, I'd like to comment on two added requires in the devel package (no need to change anything, I just feel verbose today): > Requires: gtk-doc This is fine right now, but keep an eye on https://bugzilla.redhat.com/show_bug.cgi?id=604169#c28 > Requires: pkgconfig This line is only needed if you plan to use the same spec file in EPEL 4 or EPEL 5; in current Fedora releases rpm adds the pkgconfig dep automatically. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
