https://bugzilla.redhat.com/show_bug.cgi?id=1266258

Pete Walter <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
              Flags|                            |fedora-review?



--- Comment #2 from Pete Walter <[email protected]> ---
I will not repeat the fedora-review noise here. Looks nice and clean, just a
few small things:

> python-URLObject.noarch: W: summary-ended-with-dot C A utility class for 
> manipulating URLs.
> python-URLObject.src: W: summary-ended-with-dot C A utility class for 
> manipulating URLs.

rpmlint is right here. Summary shouldn't end with a full stop.


> BuildRequires:  python-devel

This should be python2-devel as per latest guidelines.

> %doc UNLICENSE

Please use %license for license files instead.

Also, might be a good idea to use the same name as the debian package uses and
go for all lower case letters for the package name:
https://packages.debian.org/source/sid/python-urlobject
What do you think?

Can you build a Python 3 subpackage as well? Debian seems to have managed it,
so it must be possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to