Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601577

Pavel Alexeev (aka Pahan-Hubbitus) <pa...@hubbitus.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #11 from Pavel Alexeev (aka Pahan-Hubbitus) <pa...@hubbitus.info> 
2010-08-03 09:22:50 EDT ---
If we don't known exact license, I think we should use most restrictive, in our
case GPLv2+. If you are doubt, you can fire FELegal flag to get clarification
from Spot.

/usr/lib/liblockfile.so (without number) is devel file and must go to the
appropriate sub-package.

Hm, now I see Library, occasionally it did not produced in Fedora 11, where I
did try it build before. New package even not build. On Fedora 13 build fine.

Compilation done with command:
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -Wall -D_GNU_SOURCE -I. -DLIB
-DLOCKPROG=\"/usr/bin/dotlockfile\" \
                        -c lockfile.c

As you can see there no -fPIC flag. You have choose patch make scripts (and set
it upstream), or try add it to CFLAGS environment with comment.

Libs and devel sub-packages should require versioned main package.

I also do not understand error no-ldconfig-symlink :( . I try ask friends.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to