https://bugzilla.redhat.com/show_bug.cgi?id=1268910



--- Comment #1 from Michael Cronenworth <m...@cchtml.com> ---
Unofficial review:
Source URL guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags
 Change: https://github.com/h2o/h2o/archive/v%{version}.tar.gz
     to:
https://github.com/h2o/h2o/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
 and update your tarball file name.

A few nice-to-haves, but not blockers, are to use %autosetup instead of %setup
to negate requiring %patch lines and removing %defattr(-,root,root).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to