https://bugzilla.redhat.com/show_bug.cgi?id=1270554
Raphael Groner <projects...@smart.ms> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org |projects...@smart.ms
Flags| |fedora-review?
--- Comment #3 from Raphael Groner <projects...@smart.ms> ---
# The source of this package was pulled from upstreams's vcs.
# It is because the Github-created tar does not inslude submodules.
- You may use Source0: and Source1: (value is accessible respectively as
%{SOURCE1}) for both individual tar downloads. Arrange the files in %prep after
untar with %setup0 and %setup1 or use directly the tar command.
- Please remove the now obsolete Group: and Buildroot: tags.
# https://github.com/HaxeFoundation/ocamllibs/pull/19
Patch0: haxe-libs-license.patch
- It's okay to ask upstream and suggest a patch. But please remove it from the
package, license is completely a thing of upstream and shouldn't be modified at
all in Fedora.
%install
rm -rf %{buildroot}
- You can remove the rm line, it's useless.
- Use cp -p to preserve timestamps.
%files
%defattr(-,root,root,-)
- Please remove %defattr, it's not needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
