https://bugzilla.redhat.com/show_bug.cgi?id=1266806
Tom "spot" Callaway <tcall...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tcall...@redhat.com
Assignee|nob...@fedoraproject.org |tcall...@redhat.com
Flags| |fedora-review+
--- Comment #1 from Tom "spot" Callaway <tcall...@redhat.com> ---
Bonus review!
Good:
- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %license, matches source
- spec file legible, in am. english
- source matches upstream
(19aa299a36e66c4366e699a6c6bcb06e0b5459e7b8652f5d556fe5950fc0739a)
- package compiles on f23 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- javadoc okay
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
