https://bugzilla.redhat.com/show_bug.cgi?id=1281538
gil cattaneo <punto...@libero.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #3 from gil cattaneo <punto...@libero.it> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Maven packages should use new style packaging
Note: If possible update your package to latest guidelines
See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven
Please, consider this option
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/acls/name/umlgraph
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
IGNORE
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated". 260 files have
unknown license. Detailed output of licensecheck in
/home/gil/1281538-umlgraph/licensecheck.txt
These java source files are without license headers. Please, ask to upstream to
add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/ContextView.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/InterfaceMatcher.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/PackageMatcher.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/PackageView.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/RelationDirection.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/RelationPattern.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/RelationType.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/SubclassMatcher.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/UmlGraphDoc.java
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/UMLOptions.java
This file should be regenerate
UMLGraph-R5_7_2/src/main/java/org/umlgraph/doclet/Version.java
see buld.xml @ line 52
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
Please, remove %%doc macro in javadoc sub package
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: POM files have correct Maven mapping
Note: Some add_maven_depmap calls found. Please check if they are
correct or update to latest guidelines
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
umlgraph-javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: umlgraph-5.7.2-10.fc24.noarch.rpm
umlgraph-javadoc-5.7.2-10.fc24.noarch.rpm
umlgraph-5.7.2-10.fc24.src.rpm
umlgraph.noarch: W: invalid-url URL: http://umlgraph.org/ <urlopen error timed
out>
umlgraph-javadoc.noarch: W: invalid-url URL: http://umlgraph.org/ <urlopen
error timed out>
umlgraph.src: W: invalid-url URL: http://umlgraph.org/ <urlopen error timed
out>
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: File o directory non esistente
umlgraph-javadoc.noarch: W: invalid-url URL: http://umlgraph.org/ <urlopen
error timed out>
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires
--------
umlgraph (rpmlib, GLIBC filtered):
graphviz
java-headless
jpackage-utils
umlgraph-javadoc (rpmlib, GLIBC filtered):
javapackages-tools
jpackage-utils
Provides
--------
umlgraph:
mvn(org.umlgraph:umlgraph)
mvn(org.umlgraph:umlgraph:pom:)
umlgraph
umlgraph-javadoc:
umlgraph-javadoc
Source checksums
----------------
https://github.com/dspinellis/umlgraph/archive/R5_7_2.tar.gz#/umlgraph-5.7.2.tar.gz
:
CHECKSUM(SHA256) this package :
b4b0c6236c792d9d4d75265c19f3021a7224d388c8995d06cf60785c8eebf22f
CHECKSUM(SHA256) upstream package :
b4b0c6236c792d9d4d75265c19f3021a7224d388c8995d06cf60785c8eebf22f
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -b 1281538 --plugins Java -m
fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
