Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=608852 Felipe Contreras <felipe.contre...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felipe.contre...@gmail.com --- Comment #10 from Felipe Contreras <felipe.contre...@gmail.com> 2010-08-10 07:05:57 EDT --- (In reply to comment #9) > > %define gstreamer_version 0.10 > > %define dbus-glib_version 0.70 > > > BuildRequires: gstreamer-devel > gstreamer_version > > BUildRequires: dbus-glib-devel > dbus-glib_version > > > Requires: gstreamer > gstreamer_version > > This won't work. Did it even build and install? > Above you defined two macros, but below you didn't use them. So: > > BuildRequires: gstreamer-devel > %{gstreamer_version} > BUildRequires: dbus-glib-devel > %{dbus-glib_version} > Requires: gstreamer > %{gstreamer_version} > > Further, using '>' and not '>=' is somewhat unclear. GStreamer is still in the > 0.10 series for a long time, so would 0.10 be sufficient? Or does it strictly > need to be > 0.10? There is no GStreamer > 0.10; should be >=. I recommend: BuildRequires: gstreamer-devel >= 0.10 BUildRequires: dbus-glib-devel >= 0.70 This is not needed: > Requires: gstreamer > %{gstreamer_version} Because the binary would be linked to libgstreamer, so that would be automatic. > > Obsoletes: epris < 0.2 > > A comment would be good here. There is no such "epris" provided in the Fedora > package collection. *This* package is called "epris". What's the reason for > the > Obsoletes tag? Yeah, this should go away. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
