https://bugzilla.redhat.com/show_bug.cgi?id=1279579
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org |zbys...@in.waw.pl
Flags| |fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
The name should really be lowercase, it's a bother to remember complex
capitalization.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming says
"Package names should be in lower case and use dashes in preference to
underscores."
You *could* build the documentation, would be nice to have a pdf with the help.
No need to rm -rf build/ in %prep: %autosetup will recreate the whole source
directory anyway. This applies also to a few other packages that I reviewed; I
forgot to mention it before.
#!/usr/bin/env python3 → #!/usr/bin/python3.
- license is OK (Apache)
- license file is present, %license is used
- latest version
- no scriptlets needed or present
- package builds and installs
Build fails in tests, I'll kick of a scratch build.
Note to self: check explicit Requires: python3.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
