https://bugzilla.redhat.com/show_bug.cgi?id=1287846
--- Comment #4 from Antonio Trande <anto.tra...@gmail.com> ---
(In reply to mreynolds from comment #2)
> (In reply to Antonio Trande from comment #1)
> > >%{!?__python2: %global __python2 %__python}
> > >%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from
> > >>distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> >
> > You don't need to define __python2, python2_sitelib macros unless you want
> > package in RHEL 6 and older.
>
> I was just following the rpmdevtool template, I will remove these lines.
>
> >
> > >%define name lib389
> > >%define version 1.0.1
> > >%define prerel 1
> >
> > These are redundant as well.
> >
> > Do you want build lib389 in RHEL 5?
>
> No, RHEL7 and up
Okay.
>%define prerel 1
Still redundant.
>BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>Prefix: %{_prefix}
>Vendor: Red Hat Inc. <389-de...@lists.fedoraproject.org>
>rm -rf $RPM_BUILD_ROOT
>Full %clean section
>%defattr(-,root,root,-)
Set automatically; please, remove them.
- Use %{__python2} macro in %build and %install
- LICENSE must be tagged with %license
- Use %{python2_sitelib}/*, not %{python_sitelib}/*
General Guidelines: http://fedoraproject.org/wiki/Packaging:Guidelines
Guidelines for Python code: http://fedoraproject.org/wiki/Packaging:Python
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
