https://bugzilla.redhat.com/show_bug.cgi?id=1284400
--- Comment #5 from Pavol Babinčák <pbabi...@redhat.com> --- Spec URL: https://pbabinca.fedorapeople.org/koji-containerbuild/koji-containerbuild.spec SRPM URL: https://pbabinca.fedorapeople.org/koji-containerbuild/koji-containerbuild-0.5.5-1.fc23.src.rpm Differences from previous srpm: https://github.com/release-engineering/koji-containerbuild/compare/koji-containerbuild-0.5.4-3...koji-containerbuild-0.5.5-1 (In reply to Adam Miller from comment #4) > Notes > ----- > > The subpackages are missing the license. Fixed. > > BuildRoot definition is no longer needed, please remove it. > > %clean section is no longer needed, please remove it. > These are needed for EPEL 5 https://fedoraproject.org/wiki/EPEL:Packaging So I guess you can use fedora-review -D EPEL5. I'm not sure how to solve the issue it printed: - EPEL5: Package does run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. as spec file has that in the beginning of %install. > %define should be %global unless there's a specific need for %define in > macro expansion. > Fixed. > There is technically a dangling directory of /usr/lib/koji-builder-plugins > but I think that's fine since the dependency chain will pull that. You could > alternatively have the package own the directory just for good house > keeping. I don't have a firm opinion about it though and I don't consider it > a blocker for package review. I see. I guess koji could own that directory. But currently there are no plugins nor configuration in koji to reference that directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
