https://bugzilla.redhat.com/show_bug.cgi?id=1287846



--- Comment #15 from Michael Schwendt <bugs.mich...@gmx.net> ---
Created attachment 1102297
  --> https://bugzilla.redhat.com/attachment.cgi?id=1102297&action=edit
simplify topdir usage in spec file

> %setup -qc
> mv %{name}-%{version}-1 src_root

> %build
> pushd src_root

> %license src_root/LICENSE
> %doc src_root/README

This is overly complicated. What's the reason for doing it like this and moving
the source topdir to a custom src_root?

Note that rpmbuild enters the topdir _automatically_ for every spec section,
provided that it knows what the dir's name is.

What's the reason for appending -1 to the upstream version anyway? It can be
made to work with rpmbuild, see the attached patch, but as this dubious -1 will
never match the package %release, it isn't helpful.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to