https://bugzilla.redhat.com/show_bug.cgi?id=1288610



--- Comment #1 from David Shea <ds...@redhat.com> ---
fedora-review is taking its sweet time, so a couple of comments while that's
running:

- might as well just remove %check. The tests aren't hooked up via setup.py,
and actually running them requires two more packages not in fedora.

- Any reason you went with the github-generated tarball instead of the sdist
from https://pypi.python.org/pypi/lazy-object-proxy ?  The MANIFEST has
everything it's supposed to have, so the only differences in content are that
pypi does not have .gitignore, does have PKG-INFO, and does have a .egg-info
directory in src/ (which I think is supposed to be removed in %prep, though the
packaging guidelines don't say that anymore for some reason). But anyway, the
pypi tarball has a less weird name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to