https://bugzilla.redhat.com/show_bug.cgi?id=1176595

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbys...@in.waw.pl



--- Comment #16 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
Use %autosetup please with so many patches.

A single Requires/Provides per line.

%doc is used for some license files.

.so files would usually be named like libHYPRE.so.2.10.1 not
libHYPRE-2.10.1.so. With the current naming, the number is part of the file
name. I don't really know what the effect of this is. It will probably break
linking against the library... Do you have any programs using the headers and
libraries in -devel?

It seem that at least it breaks automatic MPI provides/requires generation:
$ rpm -qp -R results/hypre-openmpi-2.10.1-1.fc24.x86_64.rpm
openmpi(x86-64)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

as you can see, there are no requirements on libraries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to