https://bugzilla.redhat.com/show_bug.cgi?id=1149176
--- Comment #9 from Piotr Kliczewski <pklic...@redhat.com> --- (In reply to Douglas Schilling Landgraf from comment #6) > Hi Piotr, > > I see you updated the package. Let's start with the below, please also > consider the previous comments. > > - Point the spec and srpm to a different url, so it can easily downloaded by > wget or similar tool. > > - Source0 is not correct, the last bits seems to be 1.1.6 > > http://resources.ovirt.org/pub/ovirt-3.6-snapshot/src/vdsm-jsonrpc-java/vdsm- > jsonrpc-java-1.1.5.tar.gz > Updated > - Remove non needed BuildRoot tag > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} > -n) > https://fedoraproject.org/wiki/Java_review_template > (Buildroot definition is not present) > We have BuildRoot in line #52 > - Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/share/java/vdsm-jsonrpc-java > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > Can you point me to the lines? I do not see it. > - For subpackage that requires the main package, please use: > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > There are 3 packages: - with code - with java-doc - with src so I think there is no need to declare dependencies > - This one below, is it really needed? > %if 0%{?_use_repolib:1} > rm -rf "%{buildroot}" > %endif > > - some rpmlint issues: > vdsm-jsonrpc-java.src: W: summary-not-capitalized C oVirt JsonRpc java > client (vdsm-jsonrpc-java) > vdsm-jsonrpc-java.src: W: invalid-url Source0: > http://resources.ovirt.org/pub/ovirt-3.6-snapshot/src/vdsm-jsonrpc-java/vdsm- > jsonrpc-java-1.1.5.tar.gz HTTP Error 404: Not Found > Fixed > - Please consider run fedora-review tool with fedora-review-plugin-java > plugin, it will help during your review. New version uploaded. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
