https://bugzilla.redhat.com/show_bug.cgi?id=1270375

gil cattaneo <punto...@libero.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from gil cattaneo <punto...@libero.it> ---
NON blocking issues:

[!]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
 Please, install license files with the proper macro

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/arm-nacl
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/arm-nacl
 Please, add %dir %{_prefix}/arm-nacl

[!]: Uses parallel make %{?_smp_mflags} macro.
 Please, use the above macro, or add a comment why do not support
 parallel build
[!]: Packages should try to preserve timestamps of original installed
     files.
 Please, use
 cp -p %{SOURCE3} %{buildroot}%{_prefix}/arm-nacl/include/
 cp -p %{SOURCE4} %{buildroot}%{_prefix}/arm-nacl/include/
 or
 install -pm 644 %{SOURCE3} %{buildroot}%{_prefix}/arm-nacl/include/
 install -pm 644 %{SOURCE4} %{buildroot}%{_prefix}/arm-nacl/include/

Please, fix those problems before import

Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to