https://bugzilla.redhat.com/show_bug.cgi?id=1293735



--- Comment #10 from MartinKG <mgans...@alice.de> ---
(In reply to Dmitry Mikhirev from comment #9)
> OK, now I can finish the review officially.
> 
> >> * Error opening pdf file: cannot find boomagamerger.
> > done
> 
> Well, symlinking to %{_bindir} works, but the proper fix should be patching
> gui/kernel/tmppdffile.cpp to use compile-time defined path to search
> boomagamerger instead hardcoded:
> 
>  dirs << QApplication::applicationDirPath() + "/../lib/boomaga/";
> 
> The correct path can be passed by cmake as macro definition. It is upstream
> bug, because gui/pdfmerger/CMakeLists.txt respects LIB_SUFFIX, but the code
> does not. Please open an issue or pull request.

I reported this bug upstream:
https://github.com/Boomaga/boomaga/issues/32
but the mentioned solution from the developer doesn't work.

> 
> > boomaga.spec:59: E: hardcoded-library-path in %{_prefix}/lib/cups/backend
> 
> I'm sorry, that's my mistake. The resulting path is correct now, but another
> macro should be used: %{_exec_prefix} instead %{_prefix}. The even better
> option is to use the %{_cups_serverbin} macro provided by the cups-devel
> package to ensure that the path will remain correct after possible changes
> in cups packaging.

done

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to