https://bugzilla.redhat.com/show_bug.cgi?id=1298978
Jared Smith <jsmith.fed...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsmith.fed...@gmail.com
Assignee|nob...@fedoraproject.org |jsmith.fed...@gmail.com
Flags| |fedora-review?
--- Comment #3 from Jared Smith <jsmith.fed...@gmail.com> ---
The package looks fairly good on first glance, but it would be nice if you
added a %global called "enable_tests" that could be flipped on (in the future),
and a comment stating that the tests won't work with the current version of
nodejs-tap.
If you add that, I'll finish up the formal review this afternoon.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
